On Thu, Jun 22, 2006 at 08:52:17PM -0400, jamal wrote: > > It does feel like the qdisc_is_running though is now a replacement > for the need for dev->txlock which existed to protect multi-cpus from > entering the device transmit path. Is that unintended side effect? > i.e why would dev->txlock be needed anymore in that path?
It's not totally redundant yet since you can set tx_queue_len to zero. It also still protects against the asynchronous paths that take xmit_lock. However, it wouldn't be a bad idea to see if there is a way to reduce the number of locks required on the xmit path to one. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html