On Thu, 22 Jun 2006, Per Liden wrote:
> +static void link_reset_all(unsigned long addr)
> +{
> + struct node *n_ptr;
> + char addr_string[16];
> + u32 i;
> +
> + read_lock_bh(&tipc_net_lock);
> + n_ptr = tipc_node_find((u32)addr);
> + if (!n_ptr) {
> + read_unlock_bh(&tipc_net_lock);
> + return; /* node no longer exists */
> + }
> +
> + tipc_node_lock(n_ptr);
You already have bh's disabled here, and tipc_node_lock() also disables
them.
Not sure if it's really worth worrying about but if so, you could perhaps
implement tipc_node_lock_bh() and tipc_node_lock().
- James
--
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
