On 6/21/06, Ben Greear <[EMAIL PROTECTED]> wrote:
Kok, Auke wrote:
> CRC stripping is breaking SMBUS-connected BMC's. We disable this
> feature to make it work. This fixes related bugs regarding SOL.
Shouldn't you also have to subtract 4 bytes when setting the skb len
in the receive logic? Perhaps when setting the rx-bytes counter as well?
we thought about this, but most drivers don't strip the CRC, and we
couldn't find any tests including bridging that cared if the CRC was
there in the indicated packet.
If you can find me a failing case I'll fix it. It was much simpler to
leave it out, especially when we add back in the multiple descriptor
receive code in the future (think about the case when subtracting the
CRC makes the last descriptor disappear)
Once again, let me know if you have info I don't :-)
Thanks for the review,
Jesse
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
