> -----Original Message----- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, December 29, 2016 2:43 AM > To: Kweh, Hock Leong <hock.leong.k...@intel.com>; David Miller > <da...@davemloft.net> > Cc: joao.pi...@synopsys.com; peppe.cavall...@st.com; > seraphin.bonna...@st.com; alexandre.tor...@gmail.com; > manab...@gmail.com; niklas.cas...@axis.com; jo...@kernel.org; > pa...@ucw.cz; Ong, Boon Leong <boon.leong....@intel.com>; Voon, Weifeng > <weifeng.v...@intel.com>; lars.pers...@axis.com; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and > stmmac_dvr_probe > > On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote: > >> -----Original Message----- > >> From: David Miller [mailto:da...@davemloft.net] > >> Sent: Wednesday, December 28, 2016 12:34 AM > >> To: Kweh, Hock Leong <hock.leong.k...@intel.com> > >> Cc: joao.pi...@synopsys.com; peppe.cavall...@st.com; > >> seraphin.bonna...@st.com; f.faine...@gmail.com; > >> alexandre.tor...@gmail.com; manab...@gmail.com; > >> niklas.cas...@axis.com; jo...@kernel.org; pa...@ucw.cz; Ong, Boon > >> Leong <boon.leong....@intel.com>; Voon, Weifeng > >> <weifeng.v...@intel.com>; lars.pers...@axis.com; > >> netdev@vger.kernel.org; linux-ker...@vger.kernel.org > >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize > >> stmmac_open and stmmac_dvr_probe > >> > >> From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> > >> Date: Tue, 27 Dec 2016 22:42:36 +0800 > >> > >>> From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> > >> > >> You are not the author of this change, do not take credit for it. > >> > >> You have copied Florian's patch character by character, therefore he > >> is the author. > >> > >> You also didn't CC: the netdev mailing list properly. > > > > Hi David & Florian, > > > > Just to clarify that I do not copy exactly from Florian. > > I have changed it to have proper handling on mdio unregister while > > netdev_register() failed as showed below: > > > > return 0; > > > > -error_mdio_register: > > - unregister_netdev(ndev); > > error_netdev_register: > > + stmmac_mdio_unregister(ndev); > > Although this is required, we can't be doing it in all circumstances, we need > to > mimic what stmmac_drv_remove() does. > > Let me submit an incremental fix which takes care of mdio bus unregistration. > -- > Florian
Noted & Thanks. Will test it out once you submitted. Thanks & Regards, Wilson
