> -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Tuesday, December 27, 2016 12:55 PM > To: Kweh, Hock Leong <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Ong, Boon Leong <[email protected]>; > [email protected]; [email protected]; Voon, Weifeng > <[email protected]>; [email protected] > Subject: Re: [PATCH] net: stmmac: synchronize stmmac_open and > stmmac_dvr_probe > > From: "Kweh, Hock Leong" <[email protected]> > Date: Tue, 27 Dec 2016 19:44:59 +0800 > > > From: "Kweh, Hock Leong" <[email protected]> > > > > If kernel module stmmac driver being loaded after OS booted, there is a > > race condition between stmmac_open() and stmmac_mdio_register(), which is > > invoked inside stmmac_dvr_probe(), and the error is showed in dmesg log as > > PHY not found and stmmac_open() failed: > ... > > The resolution used wait_for_completion_interruptible() to synchronize > > stmmac_open() and stmmac_dvr_probe() to prevent the race condition > > happening. > > > > Signed-off-by: Kweh, Hock Leong <[email protected]> > > The proper thing to do is to make sure register_netdevice() is not > invoked until it is %100 safe to call stmmac_open().
Noted & thanks. Will look into it. Regards, Wilson
