Hello,
On Wed, 21 Dec 2016, Neil Horman wrote:
> On Sun, Dec 18, 2016 at 10:56:32PM +0200, Julian Anastasov wrote:
> > - tp->af_specific->sctp_xmit(head, tp);
> > + confirm = tp->dst_pending_confirm;
> > + if (confirm)
> > + head->dst_pending_confirm = 1;
> Why not use your confirm helper function here?
It is for sk, I can add a skb_set_dst_pending_confirm(skb,int)
helper, if needed.
> > + if (!t->dst_pending_confirm)
> > + t->dst_pending_confirm = 1;
> I'm not sure why you check it for being zero before setting it here, just set
> it
> unilaterally instead, or are you trying to avoid dirtying a cacheline?
Yes, no other reason. I'll change it in the next version.
Regards
--
Julian Anastasov <j...@ssi.bg>
