> -----Original Message----- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, December 15, 2016 7:33 PM > To: Nogah Frankel <nog...@mellanox.com> > Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; Jiri Pirko > <j...@mellanox.com>; Elad Raz <el...@mellanox.com>; Yotam Gigi > <yot...@mellanox.com>; Ido Schimmel <ido...@mellanox.com>; Or Gerlitz > <ogerl...@mellanox.com> > Subject: Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat > > On Thu, 15 Dec 2016 15:00:43 +0200 > Nogah Frankel <nog...@mellanox.com> wrote: > > > Extended stats are part of the RTM_GETSTATS method. This patch adds them > > to ifstat. > > While extended stats can come in many forms, we support only the > > rtnl_link_stats64 struct for them (which is the 64 bits version of struct > > rtnl_link_stats). > > We support stats in the main nesting level, or one lower. > > The extension can be called by its name or any shorten of it. If there is > > more than one matched, the first one will be picked. > > > > To get the extended stats the flag -x <stats type> is used. > > > > Signed-off-by: Nogah Frankel <nog...@mellanox.com> > > Reviewed-by: Jiri Pirko <j...@mellanox.com> > > --- > > misc/ifstat.c | 161 > ++++++++++++++++++++++++++++++++++++++++++++++++++++------ > > 1 file changed, 146 insertions(+), 15 deletions(-) > > > > diff --git a/misc/ifstat.c b/misc/ifstat.c > > index 92d67b0..d17ae21 100644 > > --- a/misc/ifstat.c > > +++ b/misc/ifstat.c > > @@ -35,6 +35,7 @@ > > > > #include <SNAPSHOT.h> > > > > +#include "utils.h" > > int dump_zeros; > > int reset_history; > > int ignore_history; > > Minor nit, please cleanup include order here (original code was wrong). > > Standard practice is: > #include system headers (like stdio.h etc) > #include "xxx.h" local headers. > > Should be: > #include <getopt.h> > > #include <linux/if.h> > #include <linux/if_link.h> > > #include "json_writer.h" > #include "libnetlink.h" > #include "utils.h" > #include "SNAPSHOT.h"
Thanks, I'll fix it.
