On Thu, Dec 15, 2016 at 12:53:49AM -0800, Vishwanathapura, Niranjana wrote:
> On Wed, Dec 14, 2016 at 11:59:34PM -0800, Vishwanathapura, Niranjana wrote:
> > +
> > +static inline bool is_hfi_ibdev(struct ib_device *ibdev)
> > +{
> > + return !memcmp(ibdev->name, "hfi", 3);
> > +}
>
> I am thinking of adding a device capability flag to indicate HFI VNIC
> capabilty instead of relying on the device name as above to identify a hfi
> ib deice.
Absolutely.
> Any comments? Probably it can be addressed by a separate patch later.
no, comparing device names is always wrong, please do it ASAP.
