On 12/13/2016 03:46 PM, Florian Fainelli wrote:
Is there a reason why the check is not moved down inwo emac_clks_phase{1,2}_init functions? Do you anticipate other ACPI-related changes in the future that would warrant having this check moved at a higher level?
No, this is the last ACPI-related change that I expect. I could move the check into those functions, but I don't see how that's any different than what I'm doing now. My way avoids calling a function altogether, your way calls into a function only to have it return immediately.
But I don't have any strong feelings either way. I will change it if you want me to.
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.