On Mon, Dec 12, 2016 at 10:37 PM, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Sat, Dec 10, 2016 at 11:06:58AM +0530, Selvin Xavier wrote: >> On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier >> <selvin.xav...@broadcom.com> wrote: >> > I am preparing a git repository with these changes as per Jason's >> > comment and will share the details later today. >> >> Please use bnxt_re branch in this git repository. >> >> https://github.com/Broadcom/linux-rdma-nxt.git > > Why are you using __packed in bnxt_re_uverbs_abi.h ? that doesn't seem > necessary. It is a good idea to make sure all those structures are a > multiple of 64 bits (add explicit reserved fields), and make sure you > test 32 bit verbs as well.
Will take care in v3. > > Why are you using debugfs just to export counters? Isn't the core code > counter framework good enough? I agree that some of the counters exported by this patch set, tx and rx bytes/pkts etc, can be exported through the core counters. i will try adding this support in v3, if not, will post as a separate patch. debugfs was introduced more for the future, in case any HW specific data needs to be displayed. As of now, it tracks only the count of resources( CQ/MR/QPs) active at any given point. So its ok to skip this patch from this series. > > Please try and avoid writing functions as defines (eg rdev_to_dev, > to_bnxt_re, SQE_PG, RCFW_CMDQ_COOKIE, PTR_PG etc) > Sure, will take care in v3. > There is something wrong with the tabs and spaces (see > https://github.com/Broadcom/linux-rdma-nxt/blob/03e23b087f7e86ea28656273994e065827210ce5/drivers/infiniband/hw/bnxtre/bnxt_re_hsi.h) > > FWIW, I really dislike the column alignment style, it is so hard to > maintain.. This file contains the Macro defines for the FW/HW structures and are auto-generated. Some of these auto-generated defines are very long which makes the lines greater than 80 characters. I will fix whatever possible and include in v3 set. > > Jason Thanks, Selvin
