Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

[Vivien Didelot]

Hi Volodymyr,

Volodymyr Bendiuga <volodymyr.bendi...@gmail.com> writes:

> +struct pvec_tbl_entry {
> +        struct hlist_node entry;
> +        u32 key_crc32; /* key */
> +        u16 pvec;
> +        struct pvec_tbl_key {
> +                u8 addr[ETH_ALEN];
> +                u16 fid;
> +        } key;
> +};
> +
>  struct mv88e6xxx_atu_entry {
>       u16     fid;
>       u8      state;

Also, if we were to cache some values in mv88e6xxx, I'd use the existing
structures which match the hardware definition. Easier to understand.

mv88e6xxx_atu_entry already represents an ATU entry with its port
vector, FID, MAC address and more. Do you think it can be used here?

Thanks,

        Vivien