> -----Original Message-----
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Andrew Lunn
> Sent: Thursday, December 08, 2016 10:12 PM
> To: maowenan
> Cc: netdev@vger.kernel.org; jeffrey.t.kirs...@intel.com
> Subject: Re: [PATCH] net: add one ethtool option to set relax ordering mode
>
> On Thu, Dec 08, 2016 at 02:51:37PM +0800, Mao Wenan wrote:
> > This patch provides one way to set/unset IXGBE NIC TX and RX relax
> > ordering mode, which can be set by ethtool.
> > Relax ordering is one mode of 82599 NIC, to enable this mode can
> > enhance the performance for some cpu architecure.
> > example:
> > ethtool -s enp1s0f0 relaxorder off
> > ethtool -s enp1s0f0 relaxorder on
>
> Since this is a simple on/off, could it not be done with a feature?
> ethtool --feature?
>
> Andrew
Hello Andrew,
Thank you for your comments.
I get your idea about using ethtool -K|--feature is good for this
feature, right?
My original concert is about this is a relax ordering mode exist in 82599, it
is the hardware
related feature. And ethtool -s option is related hardware of phy and other
(e.g: speed, duplex...),
it is very easy to implement in do_sset().
But ethtool -K is mainly used for protocol offload,
ethtool -K|--features|--offload DEVNAME Set protocol offload and other
features
FEATURE on|off ...
@Jeff Kirsher, what's your comments?
