On 12/08/2016 02:36 PM, Alexandre Torgue wrote: > Hi Niklas, > > On 12/05/2016 05:18 PM, Niklas Cassel wrote: >> Hello Giuseppe >> >> >> I'm trying to figure out what snps,axi_all is supposed to represent. >> >> It appears that the value is saved, but never used in the code. >> >> Looking at the register specification, I'm guessing that it represents >> Address-Aligned Beats, but there is already the property snps,aal >> for that. > > IMO, it is not useful. Indeed AXI_AAL is a read only bit (in AXI bus mode > register) and reflects the aal bit in DMA bus register. > As you know we use "snps,aal" to set aal bit in DMA bus register. > So "snps,axi_all" entry seems useless. Let's see with Peppe.
Ok, I see. GMAC and GMAC4 is different here. For GMAC4 AAL only exists in DMA_SYS_BUS_MODE. It's not reflected anywhere else. The code is correct in the driver. If snps,axi_all is just created for a read-only register, and it is currently never used in the code, while we have snps,aal, which is correct and works, I guess it should be ok to remove snps,axi_all. I can cook up a patch. > > Regards > Alex > >> >> >> Regards, >> Niklas >>
