Re: [Intel-wired-lan] [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

[Rustad, Mark D]

Zhouyi Zhou <zhouzho...@gmail.com> wrote:

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index fee1f29..4926d48 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

                                total_rx_bytes += ddp_bytes;
                                total_rx_packets += DIV_ROUND_UP(ddp_bytes,
                                                                 mss);
-                       }
-                       if (!ddp_bytes) {
+                       } else {
                                dev_kfree_skb_any(skb);
                                continue;
                        }

@@ -2173,8 +2173,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,

--
Mark Rustad, Networking Division, Intel Corporation

This is changing the logic by treating a negative ddp_bytes value (an error return) the same as a 0 value. This is probably wrong and inappropriate for this patch in any case.

signature.asc
Description: Message signed with OpenPGP using GPGMail