From: Paolo Abeni > Sent: 06 December 2016 17:08 ... > @@ -79,6 +82,9 @@ struct udp_sock { > int (*gro_complete)(struct sock *sk, > struct sk_buff *skb, > int nhoff); > + > + /* since we are prone to drops, avoid dirtying any sk cacheline */ > + atomic_t drops ____cacheline_aligned_in_smp; > };
Isn't that likely to create a large hole on systems with large cache lines. (Same as any other use of ____cacheline_aligned_in_smp.) David