On Sat, 3 Dec 2016 19:33:23 +0800 Pan Bian <bianpan2...@163.com> wrote:
> Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 > > Signed-off-by: Pan Bian <bianpan2...@163.com> > --- > net/bridge/br_sysfs_br.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c > index e120307..f88c4df 100644 > --- a/net/bridge/br_sysfs_br.c > +++ b/net/bridge/br_sysfs_br.c > @@ -898,6 +898,7 @@ int br_sysfs_addbr(struct net_device *dev) > if (!br->ifobj) { > pr_info("%s: can't add kobject (directory) %s/%s\n", > __func__, dev->name, SYSFS_BRIDGE_PORT_SUBDIR); > + err = -ENOMEM; > goto out3; > } > return 0; Makes sense. Although such a small allocation should never fail. Acked-by: Stephen Hemminger <step...@networkplumber.org>
