O
>  
> +void selinux_get_sock_sid(const struct socket *sock, u32 *sid)
> +{
> +     if (selinux_enabled) {
> +             const struct inode *inode = SOCK_INODE(sock);
> +             selinux_get_inode_sid(inode, sid);
> +             return;
> +     }
> +     *sid = 0;
> +}
> +

This is so short, it would make sense to put it in scm.h
and why not have it return the value instead of call by reference?
Same goes for selinux_get_inode_sid

static inline void selinux_get_sock_sid(const struct socket *sock, u32 *sid)
{
        if (selinux_enabled)
                selinux_get_inode_sid(SOCK_INODE(sock), sid);
        else
                *sid = 0;
}

or
static inline u32 selinux_get_sock_sid(const struct socket *sock)
{
        return selinux_enabled ? selinux_get_inode_sid(SOCK_INODE(sid)) : 0;
}
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to