From: Erik Nordmark <nordm...@arista.com>
Date: Wed, 30 Nov 2016 15:39:19 -0800

> @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb)
>  have_ifp:
>               if (ifp->flags & (IFA_F_TENTATIVE|IFA_F_OPTIMISTIC)) {
>                       if (dad) {
> +                             if (nonce != 0 && ifp->dad_nonce == nonce) {
> +                                     u8 *np = (u8 *)&nonce;
> +                                     /* Matching nonce if looped back */
> +                                     ND_PRINTK(2, notice,
> +                                               "%s: IPv6 DAD loopback for 
> address %pI6c nonce %02x:%02x:%02x:%02x:%02x:%02x ignored\n",
> +                                               ifp->idev->dev->name,
> +                                               &ifp->addr,
> +                                               np[0], np[1], np[2], np[3],
> +                                               np[4], np[5]);

I know you said you'd leave this, but I'd actually like to ask that you
use %pM here to save some kernel size.

Thank you.

Reply via email to