On Thu, Dec 1, 2016 at 3:02 PM, Eric Dumazet <[email protected]> wrote: > From: Eric Dumazet <[email protected]> > > My recent commit to get more precise rx/tx counters in ndo_get_stats64() > can lead to crashes at device dismantle, as Jesper found out. > > We must prevent mlx4_en_fold_software_stats() trying to access > tx/rx rings if they are deleted. > > Fix this by adding a test against priv->port_up in > mlx4_en_fold_software_stats() > > Calling mlx4_en_fold_software_stats() from mlx4_en_stop_port() > allows us to eventually broadcast the latest/current counters to > rtnetlink monitors. > > Fixes: 40931b85113d ("mlx4: give precise rx/tx bytes/packets counters") > Signed-off-by: Eric Dumazet <[email protected]> > Reported-and-bisected-by: Jesper Dangaard Brouer <[email protected]> > Tested-by: Jesper Dangaard Brouer <[email protected]> > Cc: Tariq Toukan <[email protected]> > Cc: Saeed Mahameed <[email protected]>
Acked-by: Saeed Mahameed <[email protected]>
