On 11/29/16 5:59 PM, Alexei Starovoitov wrote: > On Tue, Nov 29, 2016 at 05:43:08PM -0700, David Ahern wrote: >> On 11/29/16 1:01 PM, Alexei Starovoitov wrote: >>> Could you also expose sk_protcol and sk_type as read only fields? >> >> Those are bitfields in struct sock, so can't use offsetof or sizeof. Any >> existing use cases that try to load a bitfield in a bpf that I can look at? > > pkt_type, vlan are also bitfileds in skb. Please see convert_skb_access() > There is a bit of ugliness due to __BIG_ENDIAN_BITFIELD though.. >
Given the added complexity I'd prefer to defer this second use case to a follow on patch set. This one introduces the infra for sockets and I don't see anything needing to change with it to add the read of 3 more sock elements. Agree?
