Please ignore this v2 patch.
On Tue, Nov 29, 2016 at 12:29 PM, Souptick Joarder <[email protected]> wrote: > In mlx4_alloc_cmd_mailbox(), pci_pool_alloc() followed by memset will be > replaced by pci_pool_zalloc(). > > Signed-off-by: Souptick joarder <[email protected]> > --- > v2: > - Address comment from sergei > Alignment was not proper > > drivers/net/ethernet/mellanox/mlx4/cmd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c > b/drivers/net/ethernet/mellanox/mlx4/cmd.c > index e36bebc..96cdf9a 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c > +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c > @@ -2679,14 +2679,13 @@ struct mlx4_cmd_mailbox > *mlx4_alloc_cmd_mailbox(struct mlx4_dev *dev) > if (!mailbox) > return ERR_PTR(-ENOMEM); > > - mailbox->buf = pci_pool_alloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, > - &mailbox->dma); > + mailbox->buf = pci_pool_zalloc(mlx4_priv(dev)->cmd.pool, GFP_KERNEL, > + &mailbox->dma); > if (!mailbox->buf) { > kfree(mailbox); > return ERR_PTR(-ENOMEM); > } > > - memset(mailbox->buf, 0, MLX4_MAILBOX_SIZE); > > return mailbox; > } > -- > 1.9.1 >
