On Tue, 2006-06-13 at 16:58 +0200, Jan Engelhardt wrote: > >+extern int kernel_ioctl(struct socket *sock, int cmd, unsigned long arg); > >+ > > I would prefer naming it kernel_sock_ioctl, since (general) ioctl often > done on fds (or struct file * for that matter) rather than sockets.
I agree that this is misleading. My original preference was to use ksock_ prefix for all these wrapper functions. But just to be consistent with the existing kernel_sendmsg and kernel_recvmsg, i used kernel_ prefix. If it is OK, i could rename them also to use the ksock_ prefix to make them all consistent and also indicating that we are operating on sockets. If not, i will go with kernel_sock_ioctl(). Thanks Sridhar - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html