On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli <f.faine...@gmail.com> wrote:
> On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote:
>> From: Yegor Yefremov <yegorsli...@googlemail.com>
>>
>> Add the ability to query and set Energy Efficient Ethernet parameters
>> via ethtool for applicable devices.
>
> Are you sure this is enough to actually enable EEE? I don't see where
> phy_init_eee() is called here, nor is the cpsw Ethernet controller part
> configured to enable/disable EEE. EEE is not just a PHY thing, it
> usually also needs to be configured properly at the Ethernet MAC/switch
> level as well.
>
> Just curious here.

I'm sure I want to disable EEE :-) So I need this patch in order to
check and disable EEE advertising.

Yegor

Reply via email to