On Wed, Nov 23, 2016 at 3:49 PM, David Laight <david.lai...@aculab.com> wrote: > From: Alexey Dobriyan >> Sent: 19 November 2016 01:08 > ... >> - for (i = (int)skb_shinfo(skb)->nr_frags - 1; i >= 0; i--) >> + for (i = skb_shinfo(skb)->nr_frags - 1; (int)i >= 0; i--) >> len += skb_frag_size(&skb_shinfo(skb)->frags[i]); > > Think I'd use: > for (i = skb_shinfo(skb)->nr_frags; i-- != 0; )
This kind of diverges from canonical loop form: for (init; temination condition: iterator) by shifting everything into termination part. A
