From: Jiri Pirko <j...@resnulli.us>
Date: Tue, 22 Nov 2016 15:48:44 +0100
> Tue, Nov 22, 2016 at 03:25:26PM CET, r...@mellanox.com wrote:
>>tp->root is being allocated in init() time and kfreed in destroy()
>>however it is being dereferenced in classify() path.
>>
>>We could be in classify() path after destroy() was called and thus
>>tp->root is null. Verifying if tp->root is null in classify() path
>>is enough because it's being freed with kfree_rcu() and classify()
>>path is under rcu_read_lock().
>>
>>Fixes: 1e052be69d04 ("net_sched: destroy proto tp when all filters are gone")
>>Signed-off-by: Roi Dayan <r...@mellanox.com>
>>Cc: Cong Wang <cw...@twopensource.com>
>
> This is correct
>
> Reviewed-by: Jiri Pirko <j...@mellanox.com>
>
> The other way to fix this would be to move tp->ops->destroy call to
> call_rcu phase. That would require bigger changes though. net-next
> perhaps?
This patch is targetted at net-next as per Subj.
