On Mon, Nov 21, 2016 at 11:50:03PM +0000, Rosen, Rami wrote: > Hi, Amir, > > Following are three minor comments: > > Seems that TCA_TUNNEL_KEY_PAD used anywhere: I assume you ment that it is _NOT_ used anywhere: This attribute type is used in the kernel side only - for padding 64bit attributes. The userspace enum should match the kernel include/uapi one.
> > + TCA_TUNNEL_KEY_PAD, > + __TCA_TUNNEL_KEY_MAX, > +}; > > > Should be "and destination IP 11.11.0.2" instead of "and destination IP > 11.11.0.1": ack > > +Tunnel ID (for example VNI in VXLAN tunnel) .TP .B src_ip Outer header > +source IP address (IPv4 or IPv6) .TP .B dst_ip Outer header destination > +IP address (IPv4 or IPv6) .RE .SH EXAMPLES The following example > +encapsulates incoming ICMP packets on eth0 into a vxlan tunnel by > +setting metadata to VNI 11, source IP 11.11.0.1 and destination IP > +11.11.0.1 by forwarding the skb with the metadata to device vxlan0, > +which will prepare the VXLAN headers: > + > +.RS > +.EX > +#tc qdisc add dev eth0 handle ffff: ingress #tc filter add dev eth0 > +protocol ip parent ffff: \\ > + flower \\ > + ip_proto icmp \\ > + action tunnel_key set \\ > + src_ip 11.11.0.1 \\ > + dst_ip 11.11.0.2 \\ > + id 11 \\ > > > Typo: should be "ip tunnel" instead of "ip tunel": ack > > + * m_tunnel_key.c ip tunel manipulation module > + * > + * This program is free software; you can redistribute it and/or > > Keep on the good work! Thanks for reviewing, Amir > > Regards, > Rami Rosen > Intel Corporation
