On Sun, 2016-11-20 at 17:14 +0200, Tariq Toukan wrote: > Hi Eric, > > Thanks for your patch. > > On 18/11/2016 10:15 PM, Eric Dumazet wrote: > > + > > + AVG_PERF_COUNTER(priv->pstats.rx_coal_avg, polled); > Keep this perf stats update out of the if block.
This perf stat would be useless then with busy polling. And this would be the the only source of false sharing in the driver. Not that I particularly care, since AVG_PERF_COUNTER can not be enabled without modifying / recompiling the driver.
