From: Of Jiri Benc
> Sent: 15 November 2016 14:40
> On Sun, 13 Nov 2016 20:43:55 -0800, Pravin B Shelar wrote:
> > @@ -1929,8 +1951,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, 
> > struct net_device *dev,
> >     union vxlan_addr *src;
> >     struct vxlan_metadata _md;
> >     struct vxlan_metadata *md = &_md;
> > -   struct dst_entry *ndst = NULL;
> >     __be16 src_port = 0, dst_port;
> > +   struct dst_entry *ndst = NULL;
> >     __be32 vni, label;
> >     __be16 df = 0;
> >     __u8 tos, ttl;
> 
> This looks kind of arbitrary. You might want to remove this hunk or
> merge it to patch 3.

Worse than arbitrary, it adds 4 bytes of pad on 64bit systems.

        David

Reply via email to