Pravin,

please CC reviewers of the previous version when submitting a new
version. You'll get faster reviews that way.

On Sun, 13 Nov 2016 20:43:53 -0800, Pravin B Shelar wrote:
> @@ -2069,11 +2069,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct 
> net_device *dev,
>               struct dst_entry *ndst;
>               u32 rt6i_flags;
>  
> -             if (!sock6)
> -                     goto drop;
> -             sk = sock6->sock->sk;
> -
> -             ndst = vxlan6_get_route(vxlan, skb,
> +             ndst = vxlan6_get_route(vxlan, sock6, skb,
>                                       rdst ? rdst->remote_ifindex : 0, tos,
>                                       label, &dst->sin6.sin6_addr,
>                                       &src->sin6.sin6_addr,
> @@ -2093,6 +2089,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct 
> net_device *dev,
>                       goto tx_error;
>               }
>  
> +             sk = sock6->sock->sk;
>               /* Bypass encapsulation if the destination is local */
>               rt6i_flags = ((struct rt6_info *)ndst)->rt6i_flags;
>               if (!info && rt6i_flags & RTF_LOCAL &&

This moves the sk assignment from one arbitrary place to a different
arbitrary place, while it would be best to just remove it and open code
sock6->sock->sk in the call to udp_tunnel6_xmit_skb. But patch 6 does
that later, so whatever.

Acked-by: Jiri Benc <jb...@redhat.com>

Reply via email to