On 11/01/2016 10:18 AM, Timur Tabi wrote: > Pause frames are a feature that is supported by the MAC. It is the MAC > that generates the frames and that processes them. Thy PHY can only be > configured to allow them to pass. Therefore, pause frame support in the > PHY should only be enabled if the MAC wants it enabled. It should not be > forced on all the time. > > Signed-off-by: Timur Tabi <ti...@codeaurora.org>
So in premise, this is good, and is exactly what I have in mind for the series that I am cooking, but if we apply this alone, without a change in drivers/net/phy/phy.c which adds SUPPORTED_Pause | SUPPORTED_AsymPause to phydev->features, we are basically breaking the Ethernet MAC drivers that don't explicitly override phydev->features and yet rely on that to get flow control to work. -- Florian
