On Fri, Oct 28, 2016 at 7:53 PM, David Miller <da...@davemloft.net> wrote: > > I really disalike pull requests of this form. > > You add lots of datastructures and helper functions but no actual > users of these facilities to the driver. > > Do this instead: > > 1) Add TSAR infrastructure > 2) Add use of TSAR facilities to the driver > > That's one pull request. > > I don't care if this is hard, or if there are entanglements with > Infiniband or whatever, you must submit changes in this manner. >
It is not hard, it is just not right, we have lots of IB and ETH features that we would like to submit in the same kernel cycle, with your suggestion I will have to almost submit every feature (core infrastructure and netdev/RDMA usage) to you and Doug. Same for rdma features, you will receive PULL request for them as well, I am sure you and the netdev list don't need such noise. do not forget that this will slow down mlx5 progress since netde will block rdma and vise-versa. > I will not accept additions to a driver that don't even get really > used. For logic/helper functions containing patches such as "Add TSAR infrastructure" I agree and i can find a way to move some code around to avoid future conflicts and remove them from such pull requests. but you need to at least accept hardware related structures infrastructure patches for shared code such as include/linux/mlx5/mlx5_ifc.h where we have only hardware definitions and those patches are really minimal. So bottom line, I will do my best to ensure future PULL requests will contain only include/linux/mlx5/*.h hardware related definitions or fully implemented features. Can we agree on that ? Thanks, Saeed.
