On Mon, Jun 05, 2006 at 12:47:23PM -0700, Michael Chan wrote: > Remove tx_lock where it is unnecessary. tg3 runs lockless and so it > requires interrupts to be disabled and sync'ed, netif_queue and NAPI > poll to be stopped before the device can be reconfigured. After > stopping everything, it is no longer necessary to get the tx_lock.
The paths where full lock is preceded by netif_tx_disable are obviously safe (well, once you take off the LLTX flag anyway). However, there are paths that don't do netif_tx_disable (e.g., tg3_set_rx_mode), are they safe as well? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
