Dear David, > -----Original Message----- > From: David Miller [mailto:[email protected]] > Sent: Thursday, October 13, 2016 11:20 PM > To: Izumi, Taku/泉 拓 > Cc: [email protected] > Subject: Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver > > From: Taku Izumi <[email protected]> > Date: Tue, 11 Oct 2016 17:55:20 +0900 > > > This patch implements debug mode for fjes driver. > > You can get firmware activity information by enabling > > debug mode. This is useful for debugging. > > > > To enable debug mode, write value of debugging mode to > > debug_mode file in debugfs: > > > > # echo 1 > /sys/kernel/debug/fjes/fjes.0/debug_mode > > > > To disable debug mode, write 0 to debug_mode file in debugfs: > > > > # echo 0 > /sys/kernel/debug/fjes/fjes.0/debug_mode > > > > Firmware activity information can be retrieved via > > /sys/kernel/debug/fjes/fjes.0/debug_data file. > > > > Signed-off-by: Taku Izumi <[email protected]> > > There is no reason to use debugfs for this, we have facilities such > as ETHTOOL_SET_DUMP et al. that you can use to implement this.
Thank you for reviewing. I see. I'll rewrite this patch to use ethtool. Sincerely, Taku Izumi
