> Please remove the const qualifier and the casts to be consistent > with how we handle this elsewhere. > > Thanks.
I can of course trivially make that change. But: (on net-next/master) git grep 'extra[12].*=.*\(void *[*]\)' currently finds 45 matches, and this patch adds a 46th. In particular there's a ton of such examples in: drivers/parport/procfs.c kernel/sysctl.c net/rxrpc/sysctl.c security/keys/sysctl.c There's also the 2 that were added to: net/ipv6/addrconf.c (ie. same file as this patch) in my previous patch set. Should I also remove void * from those as well? Should this be left as is? Marking it explicitly as const gets the constants into the rodata section which is cpu page table masked to be read-only so it seems much safer/better... - Maciej
