On Fri, 2016-09-30 at 15:56 -0400, John W. Linville wrote: > I requested a Coverity scan of the current ethtool sources. There > weren't many issues identified, but it was non-zero. > > Most/all of the resource leak issues can be explained away as > unimportant due to the fact that ethtool invocations are short-term > processes. Nevertheless, I prefer to have those issues "fixed" both > to avoid them as distractions and just to promote better coding > practices overall.
The patch series looks good to me. Reviewed-by: Greg Rose <gr...@lightfleet.com> > > These are "fresh off the press" -- I'll re-review them again before > applying and pushing them. I appreciate any extra eyeballs that can > review them as well. > > John > -- > John W. Linville Someday the world will need a hero, and you > linvi...@tuxdriver.com might be all we have. Be ready. >
