On Friday 30 September 2016, Baoyou Xie wrote: > > We get 12 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_cxt.c:346:6: warning: no previous > prototype for 'qed_cxt_set_srq_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:353:5: warning: no previous > prototype for 'qed_cxt_get_srq_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:389:5: warning: no previous > prototype for 'qed_cxt_get_proto_cid_start' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:395:5: warning: no previous > prototype for 'qed_cxt_get_proto_tid_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:1801:6: warning: no previous > prototype for 'qed_rdma_set_pf_params' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4031:17: warning: no previous > prototype for 'qed_mcp_trace_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4133:17: warning: no previous > prototype for 'qed_reg_fifo_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4195:17: warning: no previous > prototype for 'qed_igu_fifo_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4258:17: warning: no previous > prototype for 'qed_protection_override_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6342:17: warning: no previous > prototype for 'qed_print_idle_chk_results_wrapper' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6416:17: warning: no previous > prototype for 'format_feature' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6483:17: warning: no previous > prototype for 'qed_dbg_dump' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie <baoyou....@linaro.org>
Acked-by: Arnd Bergmann <a...@arndb.de>
