On Tue, 27 Sep 2016 17:55:40 +0900, Toshiaki Makita wrote: > This adds support for envhdrlen. > > Example: > # ip link set eno1 envhdrlen 8
I don't see why this should be user visible, let alone requiring user to set it. This should be transparent, kernel should compute the value as needed based on the configuration and set it up. Requiring the administrator to pick up a calculator and sum up all the vlan, mpls and whatever header lengths is silly. I realize that we currently have no easy way to do that. Especially with lwtunnels and stuff line MPLS where we don't easily know the number of tags. But every uAPI we introduce will have to be supported forever and going a particular way just because it is easy to implement is not sustainable. At the very least, it should be configurable from the other direction. I.e. telling which interfaces can be used by vlans or MPLS (if it cannot be inferred automatically) and configuring maximum number of tags on the given vlan/mpls/whatever interface/route/whatever. Jiri
