From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Tue, 30 May 2006 15:48:38 +0400
> On Tue, May 30, 2006 at 01:34:02PM +0200, Andreas Schwab ([EMAIL PROTECTED]) > wrote: > > There is no point in testing the atomic value if the result is thrown > > away. > > It was created to put implicit smp barrier, but it is not needed there. > Your patch is correct, thank you. Right, the *_and_test() variants have SMP barriers which the normal ones do not. So it is not just a matter of giving a return value or not, there are real side effect differences. > > Signed-off-by: Andreas Schwab <[EMAIL PROTECTED]> > > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> But since you say it doesn't matter I'll apply this. Thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html