On Tue, 27 Sep 2016 10:38:41 -0600, David Ahern wrote: > On 9/27/16 1:45 AM, Jiri Benc wrote: > > On Mon, 26 Sep 2016 20:04:06 -0600, David Ahern wrote: > >> you know this code better than me, but key_extract pulls the eth > >> header and then sets network header. If MPLS labels are present then > >> it is the labels that the network_header now points to. How did come > >> to the conclusion it is after the labels? > > > > Look ~100 lines below that, to "if (eth_p_mpls(key->eth.type))". > > There's a while loop advancing network header. > > got it, thanks. so that block can drop the while loop and just set > mpls.top_lse
I think we still need to traverse the loop to set inner_network_header. Jiri
