>-----Original Message----- >From: David Miller [mailto:da...@davemloft.net] >Sent: Friday, September 23, 2016 2:06 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: j...@mojatatu.com; netdev@vger.kernel.org >Subject: Re: [PATCH net] act_ife: Add support for machines with hard_header_len >!= mac_len > >From: Yotam Gigi <yot...@mellanox.com> >Date: Wed, 21 Sep 2016 15:54:13 +0300 > >> Without that fix, the following could occur: > ... > >I don't think what you are doing in mlxsw is valid. > >You can't set hard_header_len arbitrarily, it's the MAC length. > >If you need to prepend special headers or whatever, set >->needed_headroom which is designed for this purpose.
Ok, we will fix that. Thanks for the comment! > >Thanks.