On Wed, Sep 21, 2016 at 8:59 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > On 9/20/2016 9:26 PM, Or Gerlitz wrote:
>> Now, when the SW stats are finally upstream for 4.9 in net-next, the >> correct approach >> for the VF reps counters is to follow the architecture presented there >> [1] -- and this is >> for the netlink based standard counters. Once you do that, there's no >> need to expose >> the VF HW counters through ethtool of the VF rep. > Sure. Will look into it. However, i think we can keep ethtool support also > as VFPR represents the switch port corresponding to the VF. Exactly b/c the VFPR represented the VF switch port, their "normal" stats is what you are exposing here through ethtool, you can just drop this and move to the strategy introduced in Nogah's work. Once you support TX/RX on the VFPRs you can also add the SW stats she added too.