❦ 19 septembre 2016 06:58 CEST, David Miller <[email protected]> :
>> @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct
>> net *net,
>> return rt;
>> }
>>
>> +static int ip6_nh_valid(struct rt6_info *grt,
>> + struct net_device **dev, struct inet6_dev **idev) {
>> + int ret = 0;
>
> First, this is not formatted properly. The openning brace should start
> on a new line.
>
> Second, please use "bool", "true", and "false" for the return value.
Noted for the next time. However, the v3 version of the patch doesn't
have the function anymore.
--
Avoid temporary variables.
- The Elements of Programming Style (Kernighan & Plauger)
