RE: [PATCH net-next 04/10] bnxt_en: Added support for Secure Firmware Update

[Mintz, Yuval]

> +     if (bp->hwrm_spec_code < 0x10400)
> +             return -EOPNOTSUPP;
Don't you use defines for these kind of version values?

>  static int bnxt_flash_package_from_file(struct net_device *dev,
...
> +     rc = request_firmware(&fw, filename, &dev->dev);
> +     if (rc != 0) {
If (rc)

> +     if ((install_type & 0xffff) == 0)
> +             install_type >>= 16;
! instead of "== 0". Also, this looks 'magical'.