Re: [PATCH v4 net 1/1] net sched actions: fix GETing actions

[David Miller]

From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Fri, 16 Sep 2016 16:27:04 -0400

> Fixes:
> commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer 
> array"),
> commit 824a7e8863b3 ("net_sched: remove an unnecessary list_del()")
> commit f07fed82ad79 ("net_sched: remove the leftover cleanup_a()")

Please use multiple "Fixes: " lines to reference multiple commits, like so:


Fixes: 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer array"),
Fixes: 824a7e8863b3 ("net_sched: remove an unnecessary list_del()")
Fixes: f07fed82ad79 ("net_sched: remove the leftover cleanup_a()")

> +static void cleanup_a(struct list_head *actions, int ovr)
> +{
> +     struct tc_action *a;
> +
> +     list_for_each_entry(a, actions, list) {
> +             if (ovr)
> +                     a->tcfa_refcnt--;
> +     }
> +}

Please move the invariant test outside of the loop, like so:

        if (!ovr)
                return;
        list_for_each_entry(a, actions, list)
                a->tcfa_refcnt--;

Thanks.