On Sun, Sep 18, 2016 at 9:18 PM, Kenneth Klette Jonassen <kenne...@ifi.uio.no> wrote: >> +static u64 bbr_rate_kbps(struct sock *sk, u64 rate) >> +{ >> + return bbr_rate_bytes_per_sec(sk, rate, BBR_UNIT) * 8 / 1000; > > > Consider div_u64() here to keep all builds happy. :-) This adds __udivdi3() > with the nxp powerpc toolchains I'm using. > > (Or have the one caller use bbr_rate_bytes_per_sec() instead.)
Thanks, Kenneth. We will fix this in the next revision (we like your suggested approach of just using bbr_rate_bytes_per_sec()). cheers, neal