Re: [PATCH net-next v2 2/5] cxgb4: add common api support for configuring filters

[David Miller]

From: Rahul Lakkireddy <rahul.lakkire...@chelsio.com>
Date: Tue, 13 Sep 2016 17:12:26 +0530

> +/* Fill up default masks for set match fields. */
> +static void fill_default_mask(struct ch_filter_specification *fs)
> +{
> +     unsigned int i;
> +     unsigned int lip = 0, lip_mask = 0;
> +     unsigned int fip = 0, fip_mask = 0;

Always order local variable declarations from longest to shortest
line.

Please audit your entire submission for this issue.

Thanks.