On Mon, Sep 12, 2016 at 3:21 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
> From: Jamal Hadi Salim <j...@mojatatu.com>
>
> With the batch changes that translated transient actions into
> a temporary list we lost in the translation the fact that
> tcf_action_destroy() will eventually delete the action from
> the permanent location if the refcount is zero.
>
> Example of what broke:
> ...add a gact action to drop
> sudo $TC actions add action drop index 10
> ...now retrieve it, looks good
> sudo $TC actions get action gact index 10
> ...retrieve it again and find it is gone!
> sudo $TC actions get action gact index 10
>
> Fixes:
> 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer array"),
> 824a7e8863b3 ("net_sched: remove an unnecessary list_del()")
> f07fed82ad79 ("net_sched: remove the leftover cleanup_a()")
>
> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com>Maybe the changelog/comment needs slightly improved, but that is a very minor issue. So, Acked-by: Cong Wang <xiyou.wangc...@gmail.com>
