On Fri, Sep 09, 2016 at 11:23:52AM +0530, Raju Lakkaraju wrote:
> Hi Andrew,
>
> Thank you for review the code and valuable comments.
>
> On Thu, Sep 08, 2016 at 03:27:27PM +0200, Andrew Lunn wrote:
> > EXTERNAL EMAIL
> >
> >
> > On Thu, Sep 08, 2016 at 02:47:22PM +0530, Raju Lakkaraju wrote:
> > > From: Raju Lakkaraju <[email protected]>
> > >
> > > Used Device Tree to configure the MAC Interface as per review comments and
> > > re-sending code for review
> >
> > I don't see anything about device tree in this patch...
> >
> Ethernet driver (in my BBB environment, TI cpsw driver) read the device tree
> phy interface parameter and update in phydev structure.
>
> In device tree the following code holds the phy interface configuration.
> &cpsw_emac0 {
> phy_id = <&davinci_mdio>, <0>;
> phy-mode = "rgmii";
> };
O.K, that is one place it can come from. But it is not the only,
e.g. platform data or ACPI. A better comment might be:
Configure the MAC/PHY interface as indicated in phydev->interface,
eg. GMII, RMII, RGMII.
Andrew
