On Thu, Aug 25, 2016 at 7:40 PM, Shmulik Ladkani
<shmulik.ladk...@gmail.com> wrote:
> Hi,
>
> On Thu, 25 Aug 2016 19:13:45 +0300 Hadar Hen Zion <had...@mellanox.com> wrote:
>> From: Amir Vadai <a...@vadai.me>
>>
>> Extract _ip_tun_rx_dst() and _ipv6_tun_rx_dst() out of ip_tun_rx_dst()
>> and ipv6_tun_rx_dst(), to be used without supplying an skb.
>
> Per this v3, the newly introduced helpers ate named _ip_tun_set_dst and
> _ipv6_tun_set_dst - better alter the log message to reflect that.
sure, will fix that
>> +static inline struct metadata_dst *
>> +_ipv6_tun_set_dst(const struct in6_addr saddr, const struct in6_addr daddr,
>> + __u8 tos, __u8 ttl, __be32 label, __be16 flags,
>> + __be64 tunnel_id, int md_size)
>> +{
>
> Any reason not passing in6_addr pointers, as suggested?
guess not
> This is the common practice for ipv6 address parameters.
will do
