Hi, On Wed, 24 Aug 2016 15:27:08 +0300 Amir Vadai <a...@vadai.me> wrote: > +static inline struct metadata_dst * > +_ipv6_tun_rx_dst(struct in6_addr saddr, struct in6_addr daddr, > + __u8 tos, __u8 ttl, __be32 label, > + __be16 flags, __be64 tunnel_id, int md_size) > +{
Prefer 'const struct in6_addr *saddr' parameter (daddr too). This is aligned with almost all functions having an 'in6_addr' as a parameter, to prevent the costy argument copy.